linux-kernel - Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <499364EE.1030400@tremplin-utc.net>
Date:	Thu, 12 Feb 2009 00:53:18 +0100
From:	Éric Piel <Eric.Piel@...mplin-utc.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Giuseppe Bilotta <giuseppe.bilotta@...il.com>,
	linux-kernel@...r.kernel.org, pavel@...e.cz
Subject: Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors

Andrew Morton schreef:
> Also, this comment:
> 
> /*
>  * The sensor can also generate interrupts (DRDY) but it's pretty pointless
>  * because their are generated even if the data do not change. So it's better
>  * to keep the interrupt for the free-fall event. The values are updated at
>  * 40Hz (at the lowest frequency), but as it can be pretty time consuming on
>  * some low processor, we poll the sensor only at 20Hz... enough for the
>  * joystick.
>  */
> 
> seems to be describing something which isn't there.
Actually it's describing the main architecture of the driver, and wa put 
at this place due to the two lines just _above_ this comment:
/* joystick device poll interval in milliseconds */
#define MDPS_POLL_INTERVAL 50
A poll of 50 ms = 20Hz. And it's there to explain why I decided to use 
polling although in the documentation they say that interrupt can be 
generated whenever data is updated. (even if in general it's better to 
use interrupt driven than polling based)

Suggestions are welcome to make this comment more understandable :-)

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/