linux-kernel - Re: 2.6.29-rc3-git6: Reported regressions from 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1234312384.32506.26.camel@gaiman>
Date:	Tue, 10 Feb 2009 16:33:04 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Norbert Preining <preining@...ic.at>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>,
	samr <sam@...nborg.org>
Subject: Re: 2.6.29-rc3-git6: Reported regressions from 2.6.28

On Thu, 2009-02-05 at 20:36 +0100, Ingo Molnar wrote:
> * Randy Dunlap <randy.dunlap@...cle.com> wrote:
> 
> > > kconfig was not broken at all in this case. It detected a circular 
> > > dependency and did its work well.
> > 
> > Maybe.  I haven't seen an explanation for the problems that Eric reported 
> > 2+ weeks ago.
> 
> The thing he reported 2 weeks ago is a straightforward recursive dependency 
> bug in the config entries:
> 
>   drivers/gpu/drm/Kconfig:8:error: found recursive dependency:
>    DRM -> <choice> -> DRM_I915 -> FB -> FB_I810 -> AGP -> DRM
> 
> this is the precise circular dependency problem that the I810_FB and 
> INTEL_FB changes in my patch solve.

I think the problem is that when looking at
	select FB
or
	depends on FB
I see "this thing depends on FB.  If I said select, then instead of
asking the user to enable it before seeing the option, just enable the
option for them".  Even after seeing your patch, I still don't see why
the select means that AGP depends on DRM.

But big thanks for fixing it!

-- 
Eric Anholt
eric@...olt.net                         eric.anholt@...el.com



Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)