linux-kernel - Re: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Feb 2009 08:36:59 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	x86 maintainers <x86@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64}
 builds

On Thu, 2009-02-12 at 08:26 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > 
> > * David Woodhouse <dwmw2@...radead.org> wrote:
> > 
> > > It is a steaming great pain in the arse when the value of CONFIG_64BIT
> > > explicitly written in my .config file is overridden by the value of
> > > $ARCH inferred from the environment.
> > > 
> > > If I have a 32-bit .config and I happen to build it without remembering
> > > to put 'ARCH=i386' on the make command line, it shouldn't force
> > > CONFIG_64BIT=y and reconfigure.
> > > 
> > > This patch should fix that, while still allowing defconfig to work as it
> > > currently does for both 32-bit and 64-bit environments, and still giving
> > > the default value of CONFIG_64BIT according to $ARCH. It's just that it
> > > won't _force_ a change to CONFIG_64BIT when it's set to something other
> > > than what $ARCH would imply.
> > > 
> > > Signed-off-by: David Woodhouse <David.Woodhouse@...el.com>
> > 
> > Applied to tip:x86/ugent, thanks David!
> 
> i removed it again, because it regresses randconfig behavior:

Ew, that's a nasty thing to be prioritising over day-to-day usability,
and the fact that I can't just do 'make bzImage' without it screwing up
and asking me to reconfigure.

Isn't there a CONFIG_RANDCONFIG option? We could make it
   bool "64-bit kernel" if !CONFIG_RANDCONFIG

Alternatively, we could just the top-level Makefile set ARCH=x86 when
it's inferred from the environment, and let people override it to i386
or x86_64 if they want to.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/