linux-kernel - Re: [patch 33/41] asus-laptop: Fix the led behavior with value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090212085814.GA1386@ucw.cz>
Date:	Thu, 12 Feb 2009 09:58:14 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Corentin Chary <corentincj@...aif.net>,
	Len Brown <len.brown@...el.com>,
	Thomas Renninger <trenn@...e.de>
Subject: Re: [patch 33/41] asus-laptop: Fix the led behavior with value > 1


> > > From: Corentin Chary <corentincj@...aif.net>
> > > 
> > > commit e3deda9c87ac5eef2b5d18cd0b5511370979ca26 upstream.
> > > 
> > > Fix http://bugzilla.kernel.org/show_bug.cgi?id=11613 .
> > > 
> > > Signed-off-by: Corentin Chary <corentincj@...aif.net>
> > > Signed-off-by: Len Brown <len.brown@...el.com>
> > > Cc: Thomas Renninger <trenn@...e.de>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > > 
> > > ---
> > >  drivers/misc/asus-laptop.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- a/drivers/misc/asus-laptop.c
> > > +++ b/drivers/misc/asus-laptop.c
> > > @@ -351,7 +351,7 @@ static void write_status(acpi_handle han
> > >  	static void object##_led_set(struct led_classdev *led_cdev,	\
> > >  				     enum led_brightness value)		\
> > >  	{								\
> > > -		object##_led_wk = value;				\
> > > +		object##_led_wk = (value > 0) ? 1 : 0;			\
> > 
> > "= !!value" is standard  way to do that.... for unsigned value.
> 
> No dispute here, but that's what is upstream :)

No dispute there, I just hope original author fixes it in the upstream
on one sunny day :).

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/