linux-kernel - Re: [PATCH] sysfs: sysfs_add_one tells you _where

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090212174122.GA22301@suse.de>
Date:	Thu, 12 Feb 2009 09:41:22 -0800
From:	Greg KH <gregkh@...e.de>
To:	Alex Chiang <achiang@...com>, Kay Sievers <kay.sievers@...y.org>,
	arjan@...ux.intel.com, alex.williamson@...com,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysfs: sysfs_add_one tells you _where_ the duplicate
	file is

On Thu, Feb 12, 2009 at 10:38:35AM -0700, Alex Chiang wrote:
> +	if (ret == -EEXIST) {
> +		char *path = kzalloc(PATH_MAX, GFP_KERNEL);

You forgot to check the return value of kzalloc().

Another try?

8th time's a charm?  :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/