linux-kernel - [PATCH] fs/proc/task_mmu.c: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090212185153.GA2221@ubuntu>
Date:	Fri, 13 Feb 2009 00:21:53 +0530
From:	Milind Arun Choudhary <milindchoudhary@...il.com>
To:	Kernel Janitors <kernel-janitors@...ts.osdl.org>
Cc:	FSDevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrw Morton <akpm@...ux-foundation.org>
Subject: [PATCH] fs/proc/task_mmu.c: fix sparse warnings

Fix the following sparse warnings in fs/proc/task_mmu.c :

linux.git/fs/proc/task_mmu.c:723:26: error: subtraction of different types can't work (different address spaces)
linux.git/fs/proc/task_mmu.c:725:24: error: subtraction of different types can't work (different address spaces)


Signed-off-by: Milind Arun Choudhary <milindchoudhary@...il.com>
---

 task_mmu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 9406384..ea3e892 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -720,9 +720,9 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
 	if (ret == PM_END_OF_BUFFER)
 		ret = 0;
 	/* don't need mmap_sem for these, but this looks cleaner */
-	*ppos += (char *)pm.out - buf;
+	*ppos += (char __user *)pm.out - buf;
 	if (!ret)
-		ret = (char *)pm.out - buf;
+		ret = (char __user *)pm.out - buf;
 
 out_pages:
 	for (; pagecount; pagecount--) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/