linux-kernel - Re: [PATCHv2 2/5] VFS: DazukoFS, stackable-fs, file access control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1r623ct11.fsf@fess.ebiederm.org>
Date:	Thu, 12 Feb 2009 12:14:02 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	John Ogness <dazukocode@...ess.net>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	malware-list@...ts.printk.net, eparis@...hat.com,
	hch@...radead.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCHv2 2/5] VFS: DazukoFS, stackable-fs, file access control

John Ogness <dazukocode@...ess.net> writes:

> Patch 2: Creates /dev/dazukofs.0 for userspace applications to perform
>          file access control. At this point, all applications are
>          considered to be working together (in the same group).

Please use struct pid properly.

There is no guarantee that whoever opens /dev/dazukofs.0 will
be in the global pid namespace.

So you need to properly store a struct pid reference in your
data structures, and call pid_vnr just before you pass the value to userspace.

As it is your code is broken.


Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/