linux-kernel - Re: [Bug #12604] Commit 31a12666d8f0c22235297e1c1575f82061480029 slows down Berkeley DB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0902111757030.3189@localhost.localdomain>
Date:	Wed, 11 Feb 2009 18:02:19 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Nick Piggin <npiggin@...e.de>
cc:	Jan Kara <jack@...e.cz>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Federico Cuello <fedux@...men.org.ar>,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
Subject: Re: [Bug #12604] Commit 31a12666d8f0c22235297e1c1575f82061480029
 slows down Berkeley DB

On Thu, 12 Feb 2009, Nick Piggin wrote:

> On Tue, Feb 10, 2009 at 05:28:30PM +0100, Jan Kara wrote:
> > On Sun 08-02-09 20:21:42, Rafael J. Wysocki wrote:
> > > This message has been generated automatically as a part of a report
> > > of recent regressions.
> > > 
> > > The following bug entry is on the current list of known regressions
> > > from 2.6.28.  Please verify if it still should be listed and let me know
> > > (either way).
> >   Yes, I've verified with latest git and the regression is still there.
> 
> I'm working on this FWIW...

Shouldn't we just revert it? The code does look to be broken.

It also looks like the interaction with that ever-buggy "nr_to_write" 
thing are totally wrong. I can see that whole

	if (!cycled) {
		..
		index = 0;
		goto retry
	}

doing all the wrong things: if we ever hit the combination of 
"!cycled + nr_to-write==0", we're always screwed. It simply _cannot_ do 
the right thing.

I dunno. That whole piece-of-sh*t function has been incredibly buggy this 
release. The code is an unreadable mess, and I think that "cyclic" stuff 
is part of the reason for it being messy and buggy. Please convince me 
it's worth saving, or let me revert the whole stinking pile of crud?

Please?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/