linux-kernel - [PATCH 1/2] rt/threadirqs: don't need to save irqs in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4994ae18.1358560a.454d.403b@mx.google.com>
Date:	Thu, 12 Feb 2009 19:27:08 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] rt/threadirqs: don't need to save irqs in do_hardirq()

do_hardirq() has only one caller do_irqd() in a path where irq are already
disabled. So we don't need to save irqs while holding desc->lock

Replace spin_lock_irqsave by spin_lock.

Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
---
 kernel/irq/manage.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index ed7c5e3..6e9baf8 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -905,7 +905,7 @@ static void do_hardirq(struct irq_desc *desc)
 {
 	unsigned long flags;
 
-	spin_lock_irqsave(&desc->lock, flags);
+	spin_lock(&desc->lock);
 
 	if (!(desc->status & IRQ_INPROGRESS))
 		goto out;
@@ -921,7 +921,7 @@ static void do_hardirq(struct irq_desc *desc)
 	else
 		thread_do_irq(desc);
  out:
-	spin_unlock_irqrestore(&desc->lock, flags);
+	spin_unlock(&desc->lock);
 
 	if (waitqueue_active(&desc->wait_for_handler))
 		wake_up(&desc->wait_for_handler);
-- 
1.6.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/