linux-kernel - Re: [PATCH 9/9] staging/sxg: fix napi interface build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090212.152205.81876086.davem@davemloft.net>
Date:	Thu, 12 Feb 2009 15:22:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	gregkh@...e.de
Cc:	greg@...ah.com, randy.dunlap@...cle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] staging/sxg: fix napi interface build

From: Greg KH <gregkh@...e.de>
Date: Thu, 12 Feb 2009 15:08:46 -0800

> On Thu, Feb 12, 2009 at 02:56:20PM -0800, David Miller wrote:
> > From: Greg KH <greg@...ah.com>
> > Date: Thu, 12 Feb 2009 11:51:33 -0800
> > 
> > > On Wed, Feb 11, 2009 at 01:22:56PM -0800, Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@...cle.com>
> > > > 
> > > > Fix staging/sxg napi interface calls:
> > > > 
> > > > drivers/staging/sxg/sxg.c:1271: error: implicit declaration of function 'netif_rx_schedule_prep'
> > > > linux-next-20090209/drivers/staging/sxg/sxg.c:1272: error: implicit declaration of function '__netif_rx_schedule'
> > > > drivers/staging/sxg/sxg.c:1325: error: implicit declaration of function 'netif_rx_complete'
> > > 
> > > As I count over 80 instances of netif_rx_complete in Linus's tree right
> > > now, I'm guesing this is due to a change from the netdev tree.  Which is
> > > fine, but I'll wait until that gets merged with Linus to apply this
> > > patch.
> > 
> > Well it means that it won't build in -next until the next merge
> > window.
> 
> I can live with that :)
> 
> Or is the new api already there and it's safe to make this change now?

If you make the change, your driver will build in Linus's
tree.  Just sed 's/netif_rx_/napi_/' for the lines the
above warning triggers on.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/