linux-kernel - Re: [PATCH] nfs: replace uses of __constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f6ef82b3d3f7eb8445e2e40ce3b534d.squirrel@neil.brown.name>
Date:	Thu, 12 Feb 2009 14:15:06 +1100 (EST)
From:	"NeilBrown" <neilb@...e.de>
To:	"Harvey Harrison" <harvey.harrison@...il.com>
Cc:	"J. Bruce Fields" <bfields@...ldses.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"LKML" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfs: replace uses of __constant_{endian}

On Thu, February 12, 2009 1:52 pm, Harvey Harrison wrote:
> On Thu, 2009-02-12 at 13:50 +1100, NeilBrown wrote:
>> On Thu, February 12, 2009 12:16 pm, Harvey Harrison wrote:
>> > The base versions handle constant folding now, none of these headers
>> > are exported to userspace, so the __ prefixed versions are not
>> > necessary.
>>
>> I assume you compile tested this?
>>
>> I seem to recall that the reason we did it that way was that
>> some of the error codes are used in switch statements, and
>> the value for a 'case:' really has to look like a constant, not just
>> happen to evaluate to one.
>
> Yes, this requirement was explicitly built-in.  See how the various
> __swabXX bits are done in linux/swab.h.

Cool, thanks!

NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/