linux-kernel - Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090211162944.c1cdf8fb.akpm@linux-foundation.org>
Date:	Wed, 11 Feb 2009 16:29:44 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ed Cashin <ecashin@...aid.com>
Cc:	linux-kernel@...r.kernel.org, karaluh@...aluh.pl,
	ecashin@...aid.com
Subject: Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

On Wed, 11 Feb 2009 19:16:44 -0500
Ed Cashin <ecashin@...aid.com> wrote:

> The Welland ME-747K-SI AoE target generates unsolicited AoE
> responses that are marked as vendor extensions.  Instead of
> ignoring these packets, the aoe driver was generating kernel
> messages for each unrecognized response received.  This patch
> corrects the behavior.
> 
> Signed-off-by: Ed Cashin <ecashin@...aid.com>
> Reported-by: karaluh@...aluh.pl
> Tested-by: karaluh@...aluh.pl
> ---
> 
> I will place this patch in the new aoe quilt tree for
> linux-next when this patch has passed LKML review.
> 
>  drivers/block/aoe/aoe.h    |    1 +
>  drivers/block/aoe/aoenet.c |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
> index c237527..5e41e6d 100644
> --- a/drivers/block/aoe/aoe.h
> +++ b/drivers/block/aoe/aoe.h
> @@ -18,6 +18,7 @@
>  enum {
>  	AOECMD_ATA,
>  	AOECMD_CFG,
> +	AOECMD_VEND_MIN = 0xf0,
>  
>  	AOEFL_RSP = (1<<3),
>  	AOEFL_ERR = (1<<2),
> diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
> index 30de5b1..c6099ba 100644
> --- a/drivers/block/aoe/aoenet.c
> +++ b/drivers/block/aoe/aoenet.c
> @@ -142,6 +142,8 @@ aoenet_rcv(struct sk_buff *skb, struct net_device *ifp, struct packet_type *pt,
>  		aoecmd_cfg_rsp(skb);
>  		break;
>  	default:
> +		if (h->cmd >= AOECMD_VEND_MIN)
> +			break;	/* don't complain about vendor commands */
>  		printk(KERN_INFO "aoe: unknown cmd %d\n", h->cmd);
>  	}
>  exit:

Do you believe that this fix should be backported into earlier kernel
versions?  (2.6.28.x, 2.6.27.x, etc)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/