linux-kernel - Re: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090213111222.GA15679@elte.hu>
Date:	Fri, 13 Feb 2009 12:12:22 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	x86 maintainers <x86@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64}
	builds


* H. Peter Anvin <hpa@...or.com> wrote:

> David Woodhouse wrote:
>>
>> Ew, that's a nasty thing to be prioritising over day-to-day usability,
>> and the fact that I can't just do 'make bzImage' without it screwing up
>> and asking me to reconfigure.

That argument is flawed because it could be used against just about any
regression that happens in the kernel: if only the new behavior is
deemed more important than the regression that it introduces.

As i said, there's no real problem here, i dont mind the change you are
proposing, but it needs to be done without introducing clearly
nonsensical regressions.

>> Isn't there a CONFIG_RANDCONFIG option? We could make it
>>    bool "64-bit kernel" if !CONFIG_RANDCONFIG
>>
>> Alternatively, we could just the top-level Makefile set ARCH=x86 when
>> it's inferred from the environment, and let people override it to i386
>> or x86_64 if they want to.
>>
>
> I think the fundamental problem here is that "make randconfig" is  
> allowed to retain *any* information from the previous .config; the same  
> is true for "make all*config", "make defconfig", etc.  These by  
> definition should blast the current configuration away.
>
> Now, "make randconfig" should ideally be able to generate either a 32-  
> or a 64-bit configuration (which would have to be done correctly), but  
> if ARCH is set we need to honor it.

Yep, as long as an explicit ARCH override is honored i dont mind some
side-effects on randconfig. (although people do have scripting around
randconfig so we need to make sure it's all sane.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/