linux-kernel - Re: [PATCH 1/1] ipw2200, fix ipw io functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1234539854.3173.6.camel@localhost>
Date:	Fri, 13 Feb 2009 10:44:14 -0500
From:	Dan Williams <dcbw@...hat.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linville@...driver.com, linux-wireless@...r.kernel.org,
	ipw2100-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Zhu Yi <yi.zhu@...el.com>,
	James Ketrenos <jketreno@...ux.intel.com>,
	Reinette Chatre <reinette.chatre@...el.com>
Subject: Re: [PATCH 1/1] ipw2200, fix ipw io functions

On Thu, 2009-02-12 at 22:29 +0100, Jiri Slaby wrote:
> - some of them are defined as follows:
>   #define ipw_write32	expr1; expr2
>   and are called from loops or ifs without a compound statement, so
>   they are broken. Fix it by putting them into do {} while (0) for
>   writes and ({ }) for reads.
> - also unify and cleanup them while at it -- convert them from
>   macros to inline functions, so that we get some basic typechecking
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Zhu Yi <yi.zhu@...el.com>
> Cc: James Ketrenos <jketreno@...ux.intel.com>
> Cc: Reinette Chatre <reinette.chatre@...el.com>

I've been running with this patch for 15 hours or so and it works well
for me.  It may have even fixed random issues with the card crapping out
after resume (successful association, does DHCP, but after a minute or
two no longer passes traffic until a hard reboot even with multiple
rmmod/modprobe runs), though that could also be hallucination on my
part.

Dan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/