linux-kernel - Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4995BF9F.2050509@goop.org>
Date:	Fri, 13 Feb 2009 10:44:47 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__

Ingo Molnar wrote:
> From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@...e.hu>
> Date: Fri, 13 Feb 2009 13:36:47 +0100
> Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
>   

I think this is wrong in principle.  There should never be a reason to 
include a non-_types.h into asm.

(Fine as a build fix, of course.)

    J

> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/x86/include/asm/page_32.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/page_32.h b/arch/x86/include/asm/page_32.h
> index b3f0bf7..da4e762 100644
> --- a/arch/x86/include/asm/page_32.h
> +++ b/arch/x86/include/asm/page_32.h
> @@ -3,6 +3,8 @@
>  
>  #include <asm/page_32_types.h>
>  
> +#ifndef __ASSEMBLY__
> +
>  #ifdef CONFIG_HUGETLB_PAGE
>  #define HAVE_ARCH_HUGETLB_UNMAPPED_AREA
>  #endif
> @@ -19,8 +21,6 @@ extern unsigned long __phys_addr(unsigned long);
>  #define pfn_valid(pfn)		((pfn) < max_mapnr)
>  #endif /* CONFIG_FLATMEM */
>  
> -#ifndef __ASSEMBLY__
> -
>  #ifdef CONFIG_X86_USE_3DNOW
>  #include <asm/mmx.h>
>  
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/