lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4995D4A9.5060400@zytor.com>
Date:	Fri, 13 Feb 2009 12:14:33 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	hpa@...or.com, mingo@...hat.com,
	James.Bottomley@...senPartnership.com, tglx@...utronix.de,
	mingo@...e.hu, linux-kernel@...r.kernel.org
CC:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko]
 undefined

James Bottomley wrote:
>  arch/x86/include/asm/io.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
> index e5a2ab4..4f8e820 100644
> --- a/arch/x86/include/asm/io.h
> +++ b/arch/x86/include/asm/io.h
> @@ -125,7 +125,7 @@ static inline void *phys_to_virt(phys_addr_t address)
>  /*
>   * ISA I/O bus memory addresses are 1:1 with the physical address.
>   */
> -#define isa_virt_to_bus virt_to_phys
> +#define isa_virt_to_bus (unsigned long)virt_to_phys
>  #define isa_page_to_bus page_to_phys
>  #define isa_bus_to_virt phys_to_virt
>  

This changes one token to multiple, and not even with the highest
precedence.

It needs to be something like:

#define isa_virt_to_bus(x) ((unsigned int)virt_to_phys(x))

... if we're going to do that.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ