linux-kernel - [PATCH 0/1] Fix resume breakage of USB PCI controllers behind cardbus bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902132340.15427.rjw@sisk.pl>
Date:	Fri, 13 Feb 2009 23:40:14 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Greg KH <gregkh@...e.de>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Miles Lane <miles.lane@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: [PATCH 0/1] Fix resume breakage of USB PCI controllers behind cardbus bridges

[Sorry for resending, I forgot to send CCs to the mailing lists.]

Hi,

Unfortunately, we broke the resume of USB PCI controllers behind cardbus
bridges by moving the restoration of their standard config registers to
usb_hcd_pci_resume_early().  Namely, if USB PCI controller is behind a cardbus
bridge, we're restoring its config registers too early, before the bridge
becomes operational.

IMO in the future it's better to move the resume of cardbus bridges to the
early resume phase (ie. before device interrupts will be enabled), but for
2.6.29 I think we should just go back to the 2.6.28 behavior, which is to
call pci_restore_state() from usb_hcd_pci_resume().  The following patch
does this.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/