[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4995F979.9040304@zytor.com>
Date: Fri, 13 Feb 2009 14:51:37 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: James Bottomley <James.Bottomley@...senPartnership.com>
CC: mingo@...hat.com, tglx@...utronix.de, mingo@...e.hu,
linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko]
undefined
James Bottomley wrote:
> On Fri, 2009-02-13 at 12:14 -0800, H. Peter Anvin wrote:
>> James Bottomley wrote:
>>
>> #define isa_virt_to_bus(x) ((unsigned int)virt_to_phys(x))
>>
>> ... if we're going to do that.
>
> Actually, it probably wants to become a static inline ... that way the
> compiler can always verify the promotion and truncation is legal
> regardless of whether an actual user is compiled or not.
>
Yes, that's the right thing to do. I'll fix it up and commit a patch.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists