linux-kernel - Re: [BUG] Suspend tries to suspend devices already in D3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200902140148.32740.elendil@planet.nl>
Date:	Sat, 14 Feb 2009 01:48:32 +0100
From:	Frans Pop <elendil@...net.nl>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] Suspend tries to suspend devices already in D3

On Wednesday 04 February 2009, Rafael J. Wysocki wrote:
> On Wednesday 04 February 2009, Frans Pop wrote:
> > On Wednesday 04 February 2009, Rafael J. Wysocki wrote:
> > > On Tuesday 03 February 2009, Frans Pop wrote:
> > > > On Tuesday 03 February 2009, Frans Pop wrote:
> > > > > Looking at iwl-agn.c the cause could be that iwl_pci_suspend()
> > > > > depends on iwl_mac_stop() to call pci_save_state(). I added
> > > > > some debug statements in iwl_pci_suspend() that showed
> > > > > priv->is_open is false, so iwl_mac_stop does indeed *not* get
> > > > > called when the interface is down.
> > > >
> > > > However, iwl_mac_stop() had been called when I ran ifdown just
> > > > before suspending the system:
> > >
> > > The problem that the warning can be triggered by a device being in
> > > a low power state already before suspend should be fixed by the PCI
> > > PM fixes I've just posted.
> >
> > I'm afraid I still get the warning with your latest patches on top of
> > v2.6.29-rc3-495-gdcf6a79.
>
> If you're still getting the warning with these patches, then yes, the
> problem appears to be in iwl-agn.c .

FYI, this looks to be fixed in -rc5 by c4e061ace755 + 89c581b3fb29.

Thanks,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/