linux-kernel - Re: [PATCH next] Staging: pohmelfs: fix printk format warnings v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Feb 2009 13:25:46 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	gregkh@...e.de, frank@...eidel.de, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] Staging: pohmelfs: fix printk format warnings v2

On Fri, Feb 13, 2009 at 05:53:30PM +0300, Alexander Beregalov (a.beregalov@...il.com) wrote:
> drivers/staging/pohmelfs/inode.c:917: warning: format '%u' expects type 'unsigned int', but argument 4 has type 'size_t'
> drivers/staging/pohmelfs/inode.c:1036: warning: format '%u' expects type 'unsigned int', but argument 7 has type 'size_t'
> drivers/staging/pohmelfs/trans.c:164: warning: format '%u' expects type 'unsigned int', but argument 5 has type '__kernel_size_t'
> drivers/staging/pohmelfs/trans.c:170: warning: format '%u' expects type 'unsigned int', but argument 7 has type '__kernel_size_t'
> drivers/staging/pohmelfs/trans.c:517: warning: format '%u' expects type 'unsigned int', but argument 6 has type '__kernel_size_t'
> drivers/staging/pohmelfs/trans.c:600: warning: format '%u' expects type 'unsigned int', but argument 6 has type '__kernel_size_t'
> drivers/staging/pohmelfs/trans.c:610: warning: format '%u' expects type 'unsigned int', but argument 7 has type '__kernel_size_t'
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>

Looks good, thanks a lot Alexander.

> ---
> 
>  drivers/staging/pohmelfs/inode.c |    4 ++--
>  drivers/staging/pohmelfs/trans.c |   10 +++++-----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
> index 0980c3c..fdce752 100644
> --- a/drivers/staging/pohmelfs/inode.c
> +++ b/drivers/staging/pohmelfs/inode.c
> @@ -914,7 +914,7 @@ ssize_t pohmelfs_write(struct file *file, const char __user *buf,
>  	kiocb.ki_pos = pos;
>  	kiocb.ki_left = len;
>  
> -	dprintk("%s: len: %u, pos: %llu.\n", __func__, len, pos);
> +	dprintk("%s: len: %zu, pos: %llu.\n", __func__, len, pos);
>  
>  	mutex_lock(&inode->i_mutex);
>  	ret = pohmelfs_data_lock(pi, pos, len, POHMELFS_WRITE_LOCK);
> @@ -1033,7 +1033,7 @@ static int pohmelfs_send_xattr_req(struct pohmelfs_inode *pi, u64 id, u64 start,
>  	struct netfs_cmd *cmd;
>  	void *data;
>  
> -	dprintk("%s: id: %llu, start: %llu, name: '%s', attrsize: %u, cmd: %d.\n",
> +	dprintk("%s: id: %llu, start: %llu, name: '%s', attrsize: %zu, cmd: %d.\n",
>  			__func__, id, start, name, attrsize, command);
>  
>  	path_len = pohmelfs_path_length(pi);
> diff --git a/drivers/staging/pohmelfs/trans.c b/drivers/staging/pohmelfs/trans.c
> index 92054bd..bcb5942 100644
> --- a/drivers/staging/pohmelfs/trans.c
> +++ b/drivers/staging/pohmelfs/trans.c
> @@ -160,14 +160,14 @@ int netfs_trans_send(struct netfs_trans *t, struct netfs_state *st)
>  
>  	err = kernel_sendmsg(st->socket, &msg, (struct kvec *)msg.msg_iov, 1, t->iovec.iov_len);
>  	if (err <= 0) {
> -		printk("%s: failed to send contig transaction: t: %p, gen: %u, size: %u, err: %d.\n",
> +		printk("%s: failed to send contig transaction: t: %p, gen: %u, size: %zu, err: %d.\n",
>  				__func__, t, t->gen, t->iovec.iov_len, err);
>  		if (err == 0)
>  			err = -ECONNRESET;
>  		goto err_out_unlock_return;
>  	}
>  
> -	dprintk("%s: sent %s transaction: t: %p, gen: %u, size: %u, page_num: %u.\n",
> +	dprintk("%s: sent %s transaction: t: %p, gen: %u, size: %zu, page_num: %u.\n",
>  			__func__, (t->page_num)?"partial":"full",
>  			t, t->gen, t->iovec.iov_len, t->page_num);
>  
> @@ -514,7 +514,7 @@ int netfs_trans_finish(struct netfs_trans *t, struct pohmelfs_sb *psb)
>  		cmd->csize = psb->crypto_attached_size;
>  	}
>  
> -	dprintk("%s: t: %u, size: %u, iov_len: %u, attached_size: %u, attached_pages: %u.\n",
> +	dprintk("%s: t: %u, size: %u, iov_len: %zu, attached_size: %u, attached_pages: %u.\n",
>  			__func__, t->gen, cmd->size, t->iovec.iov_len, t->attached_size, t->attached_pages);
>  	err = pohmelfs_trans_crypt(t, psb);
>  	if (err) {
> @@ -597,7 +597,7 @@ void *netfs_trans_add(struct netfs_trans *t, unsigned int size)
>  	}
>  
>  	if (io->iov_len + size > t->total_size) {
> -		dprintk("%s: too big size t: %p, gen: %u, iov_len: %u, size: %u, total: %u.\n",
> +		dprintk("%s: too big size t: %p, gen: %u, iov_len: %zu, size: %u, total: %u.\n",
>  				__func__, t, t->gen, io->iov_len, size, t->total_size);
>  		ptr = ERR_PTR(-E2BIG);
>  		goto out;
> @@ -607,7 +607,7 @@ void *netfs_trans_add(struct netfs_trans *t, unsigned int size)
>  	io->iov_len += size;
>  
>  out:
> -	dprintk("%s: t: %p, gen: %u, size: %u, total: %u.\n",
> +	dprintk("%s: t: %p, gen: %u, size: %u, total: %zu.\n",
>  		__func__, t, t->gen, size, io->iov_len);
>  	return ptr;
>  }

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/