linux-kernel - Re: [PATCH] olpc: fix model detection without OFW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Feb 2009 17:32:37 -0500
From:	Andres Salomon <dilinger@...ued.net>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Chris Ball <cjb@...top.org>,
	Harvey Harrison <harvey.harrison@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] olpc: fix model detection without OFW

On Sat, 14 Feb 2009 23:14:29 +0100
Ingo Molnar <mingo@...e.hu> wrote:
[...]
> Where did my git grepping skills go wrong?
> 
> I git-grepped the code and this is the scope i found:
> 
> olpc_platform_info.boardrev is used for:
> 
>  - a printk
>  - olpc_board_at_least() which is used in:
>     - drivers/input/mouse/hgpk.c:                mouse driver quirk
>     - sound/pci/cs5535audio/cs5535audio_olpc.c:  audio quirk
> 
> aha. I missed this roundabout impact:
> 
>     - arch/x86/kernel/olpc.c:                    OLPC_F_DCON flag
>       - which is used in olpc_has_dcon(), which is used in:
>         - drivers/video/geode/gxfb_core.c:       GX modes db
>                                                  [ouch if this goes
> wrong!]
>         - drivers/video/geode/lxfb_core.c:       ditto
> 
> So i guess the mouse and audio quirk point was correct too, but the
> major impact is the graphics mode array mismatch and the resulting
> nonsensical mode setting, right?
> 
> 	Ingo


Yep.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/