linux-kernel - Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090214173811.4d9a0957@ephemeral>
Date:	Sat, 14 Feb 2009 17:38:11 -0500
From:	Andres Salomon <dilinger@...ued.net>
To:	Alessandro Zummo <azummo-lists@...ertech.it>
Cc:	jordan@...micpenguin.net, "David Brownell" <david-b@...bell.net>,
	linux-geode@...ts.infradead.org, dsaxena@...top.org,
	"Martin-Éric Racine" <q-funk@....fi>,
	lkml <linux-kernel@...r.kernel.org>, rpurdie@...ys.net,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

On Sat, 14 Feb 2009 23:02:35 +0100
Alessandro Zummo <azummo-lists@...ertech.it> wrote:

> On Sat, 14 Feb 2009 15:27:19 -0500
> Andres Salomon <dilinger@...ued.net> wrote:
> 
> > Sorry, I'm just now getting around to looking at this.  Why did we
> > move it from cs553x-gpio.c to geode_32.c?  I have a lemote
> > (longsoon-based) which uses cs5536:
> 
>  I've been suggested to move it within geode_32. the driver is
> probably pretty geode specific anyhow.
> 


If the whole point is to make the cs553x GPIO stuff portable (and to use
the portable API), then what's the point if we know that it can/will
be used by non-x86 platforms?

We already have a cs553x GPIO char device, a geode GPIO lib that
works (but has flaws).. I'm all for creating The One True CS553x GPIO
API, but I'd consider something that's geode (and x86)-specific to be
a waste of time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/