| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090215143433.68241a34@hyperion.delvare> Date: Sun, 15 Feb 2009 14:34:33 +0100 From: Jean Delvare <khali@...ux-fr.org> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Frank Seidel <fseidel@...e.de>, linux kernel <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org, rlove@...ve.org, protasnb@...il.com, Michael Ruoss <miruoss@...dent.ethz.ch>, Tim Gardner <tim.gardner@...onical.com>, Frank Seidel <frank@...eidel.de> Subject: Re: [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis On Sat, 14 Feb 2009 14:25:56 -0800, Dmitry Torokhov wrote: > On Fri, Feb 13, 2009 at 01:38:01PM +0100, Frank Seidel wrote: > > -module_param_named(invert, hdaps_invert, bool, 0); > > -MODULE_PARM_DESC(invert, "invert data along each axis"); > > +module_param_named(invert, hdaps_invert, int, 0); > > +MODULE_PARM_DESC(invert, "invert data along each axis. 1 invert x-axis, " > > + "2 invert y-axis, 3 invert both axes."); > > > > Why don't you make these 0644? I don't see why they can't be changed > "on fly". hdaps_invert can already be read and written via a sysfs attribute. We really don't need 2 ways to do it, so either the sysfs file or the module parameter should be dropped. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists