linux-kernel - Re: [PATCH] security/smack/smack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090215124139.ecbacba4.rdunlap@xenotime.net>
Date:	Sun, 15 Feb 2009 12:41:39 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Qinghuang Feng <qhfeng.kernel@...il.com>
Cc:	Casey Schaufler <casey@...aufler-ca.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security/smack/smack_lsm.c: cleanup kernel-doc

On Mon, 9 Feb 2009 18:58:25 +0800 Qinghuang Feng wrote:

> Remove comments which refer to nonexistent arguments.
> 
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@...il.com>
> ---
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 0278bc0..02c48ea 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -538,7 +538,6 @@ static int smack_inode_rename(struct inode *old_inode,
>   * smack_inode_permission - Smack version of permission()
>   * @inode: the inode in question
>   * @mask: the access requested
> - * @nd: unused
>   *
>   * This is the important Smack hook.
>   *
> @@ -701,8 +700,7 @@ static int smack_inode_removexattr(struct dentry *dentry, const char *name)
>   * @inode: the object
>   * @name: attribute name
>   * @buffer: where to put the result
> - * @size: size of the buffer
> - * @err: unused
> + * @alloc: unused
>   *
>   * Returns the size of the attribute or an error code
>   */
> 
> --

ACK, but there are lots of other kernel-doc problems in security/smack/
that could stand to be fixed...

Thanks,
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/