linux-kernel - Re: [PATCH] Declare PIO_CMAP/GIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Feb 2009 13:41:44 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Bill Nottingham <notting@...hat.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, trivial@...nel.org, stable@...nel.org
Subject: Re: [PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

On Wed, 11 Feb 2009 14:41:25 +0100 (CET) Jiri Kosina <jkosina@...e.cz> wrote:

> On Tue, 10 Feb 2009, Bill Nottingham wrote:
> 
> > Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.

Bill, please remember to add signoffs?  This should all be scripted.

> > ---
> >  fs/compat_ioctl.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
> > index 5235c67..9ee71a0 100644
> > --- a/fs/compat_ioctl.c
> > +++ b/fs/compat_ioctl.c
> > @@ -1937,6 +1937,8 @@ ULONG_IOCTL(SET_BITMAP_FILE)
> >  /* Big K */
> >  COMPATIBLE_IOCTL(PIO_FONT)
> >  COMPATIBLE_IOCTL(GIO_FONT)
> > +COMPATIBLE_IOCTL(PIO_CMAP)
> > +COMPATIBLE_IOCTL(GIO_CMAP)
> >  ULONG_IOCTL(KDSIGACCEPT)
> >  COMPATIBLE_IOCTL(KDGETKEYCODE)
> >  COMPATIBLE_IOCTL(KDSETKEYCODE)
> > -- 
> > 1.6.1.2
> 
> Alan, I am hesitant to consider this material implicitly applicable for 
> trivial tree.

No, it isn't appropriate for the trivial tree.

> Could you please give your Acked-by for it so that I can 
> merge, or take it through your tree completely?

afaict this fix is needed all the way back to 2.6.tiny.  I merged it
with 2.6.29 intentions.  Also tagged as needed in 2.6.25.x and later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/