linux-kernel - Re: [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41840b750902141632l5c4bd705m1b528900466a25fd@mail.gmail.com>
Date:	Sat, 14 Feb 2009 19:32:02 -0500
From:	Shem Multinymous <multinymous@...il.com>
To:	Frank Seidel <fseidel@...e.de>
Cc:	linux kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, rlove@...ve.org,
	Jean Delvare <khali@...ux-fr.org>, protasnb@...il.com,
	Michael Ruoss <miruoss@...dent.ethz.ch>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Tim Gardner <tim.gardner@...onical.com>,
	Frank Seidel <frank@...eidel.de>
Subject: Re: [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis

Hi Frank,

On Fri, Feb 13, 2009 at 7:38 AM, Frank Seidel <fseidel@...e.de> wrote:
> From: Frank Seidel <frank@...eidel.de>
>
> Fix for kernel.org bug #7154:hdaps inversion of
> each axis. This version is based on the work
> from Michael Ruoss <miruoss@...dent.ethz.ch>.
>
> Signed-off-by: Frank Seidel <frank@...eidel.de>
> ---
>  drivers/hwmon/hdaps.c |   49 ++++++++++++++++++++++++++++---------------------
>  1 file changed, 28 insertions(+), 21 deletions(-)
>
> --- a/drivers/hwmon/hdaps.c
> +++ b/drivers/hwmon/hdaps.c
> @@ -65,6 +65,10 @@
>  #define HDAPS_INPUT_FUZZ       4       /* input event threshold */
>  #define HDAPS_INPUT_FLAT       4
>
> +#define HDAPS_X_AXIS           1UL
> +#define HDAPS_Y_AXIS           2UL
> +#define HDAPS_BOTH_AXES                3UL

There are more possibilities than these: axes could also switched, for
a total of 8 possibilities.
See the table at the bottom of the tp_smapi page
(http://www.thinkwiki.org/wiki/Tp_smapi), or hdaps.c inside the
tp_smapi package, for more model-specific information.
It would be nice if you made the interface (constants and their
meaning) the same as in the tp_smapi version of hdaps, which is
already widely deployed and packaged by several distros.

  Shem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/