| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Feb 2009 15:00:31 +0100 From: Stefan Richter <stefanr@...6.in-berlin.de> To: Ingo Molnar <mingo@...e.hu> CC: Sam Ravnborg <sam@...nborg.org>, Manish Katiyar <mkatiyar@...il.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Ingo Molnar wrote: > * Stefan Richter <stefanr@...6.in-berlin.de> wrote: >> Furthermore, the changelog is bad (non-exiting in fact). >> >> The fact that the issues where discovered using checkpatch is absolutely >> uninteresting. The changelog should describe /what/ is fixed, [...] > > The commit log definitely needs enhancements but it's not uninteresting > at all what tools were used to arrive to a change. [...] if a > good and acceptable commit results out of a tool's usage then that tool > needs to be advertised some more.) Fine, then the author could mention it below the --- delimitor in the patch posting. The changelog however, as annotation of the source history, is not a billboard. We also don't describe for example that a nice cup of hot Earl Grey or whatever was vital to the creation of a patch. -- Stefan Richter -=====-==--= --=- =---- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists