linux-kernel - Re: [patch 41/47] bluetooth hid: enable quirk handling for Apple Wireless Keyboards in 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1234806514.3659.34.camel@localhost.localdomain>
Date:	Mon, 16 Feb 2009 18:48:34 +0100
From:	Torsten Rausche <torsten@...sche.net>
To:	Jan Scholz <scholz@...s.uni-frankfurt.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Jiri Kosina <jkosina@...e.cz>,
	Paul Collins <paul@...ly.ondioline.org>
Subject: Re: [patch 41/47] bluetooth hid: enable quirk handling for Apple
 Wireless Keyboards in 2.6.27

Jan Scholz writes:
> A very similar fix has been proposed by Paul Collins (see
> http://lkml.org/lkml/2008/6/14/26 ) a while ago.

Good catch, did not see that. This is essentially the same fix. One more
reason to let it go in.

> Here on my ppc32 G4 it works only if I apply the following as well.
> I can't test it on x86, though.
> 
> Jan Scholz
> 
> --
>     removed 2 calls to le16_to_cpu from the bluetooth hid quirks
>     
>     seems we're doing some endianness conversion one time to much
> 
> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> index 28dc035..6b95a6d 100644
> --- a/net/bluetooth/hidp/core.c
> +++ b/net/bluetooth/hidp/core.c
> @@ -699,8 +699,8 @@ static void hidp_setup_quirks(struct hid_device *hid)
>         unsigned int n;
>  
>         for (n = 0; hidp_blacklist[n].idVendor; n++)
> -               if (hidp_blacklist[n].idVendor == le16_to_cpu(hid->vendor) &&
> -                               hidp_blacklist[n].idProduct == le16_to_cpu(hid->product))
> +               if (hidp_blacklist[n].idVendor == hid->vendor &&
> +                               hidp_blacklist[n].idProduct == hid->product)
>                         hid->quirks = hidp_blacklist[n].quirks;
>  }

Well, then the wireless Mighty Mouse should never have worked on ppc. I
just tested these changes on my x86_64 box and the keyboard still works
fine.

Actually this is a fix for just another problem. Should these patches be
combined? How is this handled? I am not familiar with this process.

Torsten


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/