linux-kernel - Re: [PATCH] Replace deprecated __initcall with device_initcall and fix whitespaces in kernel/kallsyms.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Feb 2009 21:06:51 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Manish Katiyar <mkatiyar@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Replace deprecated __initcall with device_initcall and fix whitespaces in kernel/kallsyms.c

On Mon, Feb 16, 2009 at 09:54:25PM +0530, Manish Katiyar wrote:
> Patch to fix coding style whitespace issues and replace __initcall
> with device_initcall
> 
> Errors as reported by checkpatch.pl :-
> Before:
> total: 14 errors, 14 warnings, 487 lines checked
> After :
> total: 0 errors, 11 warnings, 486 lines checked
> 
> Compile tested binary verified as :-
> Before:
>   text    data     bss     dec     hex filename
>    2405       4       0    2409     969 kernel/kallsyms.o
> After :
>   text	   data	    bss	    dec	    hex	filename
>    2405	      4	      0	   2409	    969	kernel/kallsyms.o
> 
> 
> Signed-off-by: Manish Katiyar <mkatiyar@...il.com>

You did not fix the "spaces around operators" issue I showed you.
And you have not done an intellegent conding-style cleanup as
described in another mail by Ingo(*).

(*) As your changelog does not say so I assume you did no do it.

So please try again and be more critical this time and try to address
the issues raised.

Thanks,
	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/