linux-kernel - Re: [PATCH] spi-gpio: Implement spidelay() for busses that need it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902161242.27773.david-b@pacbell.net>
Date:	Mon, 16 Feb 2009 12:42:27 -0800
From:	David Brownell <david-b@...bell.net>
To:	Michael Buesch <mb@...sch.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi-gpio: Implement spidelay() for busses that need it.

[
  NOTE:  removed openwrt from the cc list, it rejects posts
  from non-subscribers.  Please don't cc such lists.
]

On Sunday 15 February 2009, Michael Buesch wrote:
> + * NOTE:  to clock "as fast as we can", set spi_device.max_speed_hz
> + * and spi_transfer.speed_hz to 0.

Won't work; if spi->max_speed_hz is zero, spi_async() and
friends will refuse to queue any messages.

I'm not averse to a solution that lets some boards use a
slowed-down bitbang loop.  But it would be a lot easier
if you kept the default the way it is, and just added
that slowdown as an option for the existing customization
case (currently oriented towards speedup, not slowdown).

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/