linux-kernel - Compile error in drivers/watchdog/orion5x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090216212413.GB27134@nereid>
Date:	Mon, 16 Feb 2009 22:24:14 +0100
From:	Kristof Provost <Kristof@...segv.be>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	buytenh@...tstofly.org, sylver.bruneau@...glemail.com
Subject: Compile error in drivers/watchdog/orion5x_wdt.c

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

drivers/watchdog/orion5x_wdt.c fails to compile with the following error:

  CC [M]  drivers/watchdog/orion5x_wdt.o
drivers/watchdog/orion5x_wdt.c:37: error: 'ORION5X_TCLK' undeclared here
(not in a function)
make[2]: *** [drivers/watchdog/orion5x_wdt.o] Error 1


I guess the problem is related to ebe35aff883496c07248df82c8576c3b6e84bbbe 
as it removed ORION5X_TLCK from arch/arm/mach-orion5x/include/mach/timex.h.
There are no other defines or uses of ORION5X_TLCK than in the watchdog.

I don't think simply restoring the define is the appropriate solution 
though. According to the commit log the value can be different for 
different hardware variants.

Regards,
Kristof Provost
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmZ2X0ACgkQUEZ9DhGwDuhBOgCfUubO6evdRalap8WSfF7k99I2
Bg8An1SPfFuueiU7Ndum9RNnIXLcdY7V
=qubX
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/