linux-kernel - Re: [PATCH 14/18] ide: use ->tf_read in ide_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499A09D3.8070303@ru.mvista.com>
Date:	Tue, 17 Feb 2009 03:50:27 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error()

Hello, I wrote:

>>>>       
>>>    I meant IDE_TFLAG_IN_HOB_FEATURE, of course.
>>>     
>>
>> Once again blame the certain ioctl (you know which one)... :)
>>   
>   Moreover, the error register shoudn't be affeceted by the HOB bit, 
> so this flag doesn't make sense.
>
>   Oh, horror... and I know that it wasn't completely ungrounded since 
> both ATA/PI-6 adn -7 have words about reading the features register 
> (depending on HOB). At least ATA/PI-8 got rid of this. Anyway, I think 
> we can safely get rid of this flag and just return the same value in 
> 'features' and 'hob_features'.

  Although, after thinking a bit more, it doesn't seem worth the trouble 
-- so the rename should suffice...

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/