linux-kernel - Re: [PATCH mmotm 6/6] nilfs2: replace BUG_ON and BUG calls triggerable from ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1234870088.21383.3.camel@penberg-laptop>
Date:	Tue, 17 Feb 2009 13:28:08 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH mmotm 6/6] nilfs2: replace BUG_ON and BUG calls
	triggerable from ioctl

On Tue, 2009-02-17 at 16:42 +0900, Ryusuke Konishi wrote:
> Pekka Enberg advised me:
> > It would be nice if BUG(), BUG_ON(), and panic() calls would be
> > converted to proper error handling using WARN_ON() calls. The BUG()
> > call in nilfs_cpfile_delete_checkpoints(), for example, looks to be
> > triggerable from user-space via the ioctl() system call.
> 
> This will follow the comment and keep them to a minimum.
> 
> Cc: Pekka Enberg <penberg@...helsinki.fi>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>

Looks good to me!

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/