linux-kernel - Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <76C7F485-EF75-4B83-B673-564E6243C7C6@kernel.crashing.org>
Date:	Tue, 17 Feb 2009 08:12:33 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	"<dayu@...angmobile.cn>" <dayu@...angmobile.cn>
Cc:	<LeoLi@...escale.com>, <linux-kernel@...r.kernel.org>,
	<linuxppc-dev@...abs.org>
Subject: Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)


On Feb 17, 2009, at 6:44 AM, <dayu@...angmobile.cn> <dayu@...angmobile.cn 
 > wrote:

> From: Da Yu <dayu@...angmobile.cn>
> Date: Tue, 17 Feb 2009 19:58:20 +0800
> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC  
> (2.6.23)
>
> Signed-off-by: Da Yu <dayu@...angmobile.cn>
> ---

Please provide a bit more description as to why this fixes the issue.

- k

>
>
> --- a/arch/powerpc/sysdev/ipic.c	2009-02-17 15:10:18.000000000 +0800
> +++ b/arch/powerpc/sysdev/ipic.c	2009-02-17 20:05:28.000000000 +0800
> @@ -561,8 +561,7 @@ static void ipic_ack_irq(unsigned int vi
>
> 	spin_lock_irqsave(&ipic_lock, flags);
>
> -	temp = ipic_read(ipic->regs, ipic_info[src].pend);
> -	temp |= (1 << (31 - ipic_info[src].bit));
> +	temp = 1 << (31 - ipic_info[src].bit);
> 	ipic_write(ipic->regs, ipic_info[src].pend, temp);
>
> 	spin_unlock_irqrestore(&ipic_lock, flags);
> @@ -581,8 +580,7 @@ static void ipic_mask_irq_and_ack(unsign
> 	temp &= ~(1 << (31 - ipic_info[src].bit));
> 	ipic_write(ipic->regs, ipic_info[src].mask, temp);
>
> -	temp = ipic_read(ipic->regs, ipic_info[src].pend);
> -	temp |= (1 << (31 - ipic_info[src].bit));
> +	temp = 1 << (31 - ipic_info[src].bit);
> 	ipic_write(ipic->regs, ipic_info[src].pend, temp);
>
> 	spin_unlock_irqrestore(&ipic_lock, flags);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/