linux-kernel - Re: [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902171516.34091.bzolnier@gmail.com>
Date:	Tue, 17 Feb 2009 15:16:33 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linux-ide@...r.kernel.org, Borislav Petkov <petkovbb@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec_cmd one

On Wednesday 11 February 2009, Sergei Shtylyov wrote:
> Hello.
> 
> Bartlomiej Zolnierkiewicz wrote:
> 
> >>Bartlomiej Zolnierkiewicz wrote:
> 
> >>>* Rename dma_timer_expiry() to ide_dma_sff_expiry() and export it.
> 
> >>>* Add ->dma_expiry method
> 
> >>    This name doesn't seem to make much sense. Why not leave it dma_timer_expiry?
> 
> > Well, the name matches with hwif->expiry one + the downside of leaving it at
> > dma_timer_expiry is a need to reformat all struct ide_dma_ops instances...

On the 2nd look it doesn't seem to be a problem (I must have been looking at
some odd case previously) -- I'll fix it up later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/