linux-kernel - Re: [PATCH 0/10] ide: flags query macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902171533.29135.bzolnier@gmail.com>
Date:	Tue, 17 Feb 2009 15:33:28 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Borislav Petkov <petkovbb@...glemail.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Borislav Petkov <petkovbb@...il.com>
Subject: Re: [PATCH 0/10] ide: flags query macros

On Sunday 15 February 2009, Borislav Petkov wrote:
> Hi,
> 
> this series adds the drive->atapi_flags and drive->dev_flags macro wrappers
> we discussed. The idea was to make the code more readable and this has
> been my main concern when coming up with the macro naming, therefore
> some macro names appear a tad more descriptive than the flag itself.
> 
>  drivers/ide/cmd640.c           |    2 +-
>  drivers/ide/ht6560b.c          |    3 +-
>  drivers/ide/ide-atapi.c        |   15 ++++++-------
>  drivers/ide/ide-cd.c           |   44 ++++++++++++++++++++-------------------
>  drivers/ide/ide-cd_ioctl.c     |   18 +++++++---------
>  drivers/ide/ide-devsets.c      |    8 ++----
>  drivers/ide/ide-disk.c         |   32 ++++++++++++++--------------
>  drivers/ide/ide-disk_proc.c    |    2 +-
>  drivers/ide/ide-dma.c          |    3 +-
>  drivers/ide/ide-eh.c           |   17 +++++++--------
>  drivers/ide/ide-floppy.c       |    6 ++--
>  drivers/ide/ide-floppy_ioctl.c |    2 +-
>  drivers/ide/ide-gd.c           |   14 ++++++------
>  drivers/ide/ide-io.c           |    9 +++----
>  drivers/ide/ide-ioctls.c       |    6 ++--
>  drivers/ide/ide-iops.c         |    6 ++--
>  drivers/ide/ide-lib.c          |    2 +-
>  drivers/ide/ide-park.c         |   11 ++++-----
>  drivers/ide/ide-pm.c           |    2 +-
>  drivers/ide/ide-probe.c        |   36 +++++++++++++++++---------------
>  drivers/ide/ide-proc.c         |    2 +-
>  drivers/ide/ide-tape.c         |   12 +++++-----
>  drivers/ide/ide-taskfile.c     |   16 +++++---------
>  drivers/ide/ns87415.c          |    5 +--
>  drivers/ide/pdc202xx_old.c     |    4 +-
>  drivers/ide/sc1200.c           |    2 +-
>  drivers/ide/trm290.c           |    4 +-
>  27 files changed, 136 insertions(+), 147 deletions(-)

One more thing I forgot yesterday:

Since it is not a lot of modified lines and the change is rather
straightforward it could as well be done in a single patch...

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/