linux-kernel - Re: [patch] SLQB slab allocator (try 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020902171143i5844ef83h20cb4bee4f65c904@mail.gmail.com>
Date:	Tue, 17 Feb 2009 21:43:10 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Nick Piggin <npiggin@...e.de>,
	Linux Memory Management List <linux-mm@...ck.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Lin Ming <ming.m.lin@...el.com>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Subject: Re: [patch] SLQB slab allocator (try 2)

On Tue, Feb 17, 2009 at 12:05:07PM -0500, Christoph Lameter wrote:
>> Index: linux-2.6/include/linux/slub_def.h
>> ===================================================================
>> --- linux-2.6.orig/include/linux/slub_def.h   2009-02-17 10:45:51.000000000 -0600
>> +++ linux-2.6/include/linux/slub_def.h        2009-02-17 11:06:53.000000000 -0600
>> @@ -121,10 +121,21 @@
>>  #define KMALLOC_SHIFT_LOW ilog2(KMALLOC_MIN_SIZE)
>>
>>  /*
>> + * Maximum kmalloc object size handled by SLUB. Larger object allocations
>> + * are passed through to the page allocator. The page allocator "fastpath"
>> + * is relatively slow so we need this value sufficiently high so that
>> + * performance critical objects are allocated through the SLUB fastpath.
>> + *
>> + * This should be dropped to PAGE_SIZE / 2 once the page allocator
>> + * "fastpath" becomes competitive with the slab allocator fastpaths.
>> + */
>> +#define SLUB_MAX_SIZE (2 * PAGE_SIZE)

On Tue, Feb 17, 2009 at 8:11 PM, Johannes Weiner <hannes@...xchg.org> wrote:
> This relies on PAGE_SIZE being 4k.  If you want 8k, why don't you say
> so?  Pekka did this explicitely.

That could be a problem, sure. Especially for architecture that have 64 K pages.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/