linux-kernel - Re: [PATCH] Add *.rej to .gitignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090217.143824.121552155.davem@davemloft.net>
Date:	Tue, 17 Feb 2009 14:38:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeremy@...p.org
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	sam@...nborg.org, gitster@...ox.com, mingo@...e.hu,
	caglar@...dus.org.tr
Subject: Re: [PATCH] Add *.rej to .gitignore

From: Jeremy Fitzhardinge <jeremy@...p.org>
Date: Tue, 17 Feb 2009 11:59:37 -0800

> *.rej files really are unwanted.  If there are any .rej files, they can be found by
> some other means (perhaps git itself could warn when committing with *.rej files present,
> or add some distinct notion of "ignored files" vs "never commit" files).
> 
> (This effectively reverts 1f5d3a6b6532e25a5cdf1f311956b2b03d343a48)
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>

I don't know about this.

I really want to know if there are reject files there if I
am checking to see if my tree is clean.

This has caught many patch application errors for myself
personally in the past, so I really don't want git to
start silently ignoring those things.

People should delete reject file explicitly, as they are
evidence of a patch that would not apply cleanly.  If you
abort trying to add the patch, fine, but cleaning up the
reject files is part of that operation.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/