linux-kernel - [PATCH v2] perfcounters: clean up rotate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090218212730.dde6942b.minchan.kim@barrios-desktop>
Date:	Wed, 18 Feb 2009 21:27:30 +0900
From:	MinChan Kim <minchan.kim@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH v2] perfcounters: clean up rotate_percpu


Ingo implemented rotate function at 235c7fc7c500e4fd1700c4ad01b5612bcdc1b449.
I think he want to implement rotate_percpu but he don't implement it yet.

If we need not it immediately,
It would be better to remove it until we will need it again.

Signed-off-by: MinChan Kim <minchan.kim@...il.com>
---
 kernel/perf_counter.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index ad62965..211b13b 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -970,20 +970,10 @@ static void rotate_ctx(struct perf_counter_context *ctx)
 
 void perf_counter_task_tick(struct task_struct *curr, int cpu)
 {
-	struct perf_cpu_context *cpuctx = &per_cpu(perf_cpu_context, cpu);
 	struct perf_counter_context *ctx = &curr->perf_counter_ctx;
-	const int rotate_percpu = 0;
 
-	if (rotate_percpu)
-		perf_counter_cpu_sched_out(cpuctx);
 	perf_counter_task_sched_out(curr, cpu);
-
-	if (rotate_percpu)
-		rotate_ctx(&cpuctx->ctx);
 	rotate_ctx(ctx);
-
-	if (rotate_percpu)
-		perf_counter_cpu_sched_in(cpuctx, cpu);
 	perf_counter_task_sched_in(curr, cpu);
 }
 
-- 
1.5.4.3


-- 
Kinds Regards
MinChan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/