| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ac3eb2510902180745v2886ae31s2d7faeb2faedab6e@mail.gmail.com> Date: Wed, 18 Feb 2009 16:45:08 +0100 From: Kay Sievers <kay.sievers@...y.org> To: Greg KH <gregkh@...e.de> Cc: Grant Likely <grant.likely@...retlab.ca>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Export device_add_attributes() so drivers can use it. On Wed, Feb 18, 2009 at 16:29, Greg KH <gregkh@...e.de> wrote: > On Wed, Feb 18, 2009 at 08:11:34AM -0700, Grant Likely wrote: >> From: Grant Likely <grant.likely@...retlab.ca> >> >> I find myself using the pattern of device_add_attributes() and >> device_remove_attributes() frequently in my drivers. Rather than >> reinventing the wheel every time, I'm floating this patch to export >> the symbols to see how it is received. If this looks okay then I'll >> rework my drivers and post additional patches to use these functions. > > No objection from me, as long as the symbols are EXPORT_SYMBOL_GPL(), > like the rest of the driver core. Is that ok with you? These functions used outside the core create attributes after the uevent is sent, and userspace will not see these files at event time. This is in most cases a pretty broken behavior. Is that the expected behavior in your drivers? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists