linux-kernel - Re: tip: bzip2/lzma now in tip:x86/setup-lzma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499B5BCA.8000905@zytor.com>
Date:	Tue, 17 Feb 2009 16:52:26 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Jan Engelhardt <jengelh@...ozas.de>, Alain Knaff <alain@...ff.lu>,
	the arch/x86 maintainers <x86@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: tip: bzip2/lzma now in tip:x86/setup-lzma

Ingo Molnar wrote:
> 
> still fails:
> 
> [    3.196037] initcall inet_init+0x0/0x1e9 returned 0 after 101777 usecs           
> [    3.202886] calling  af_unix_init+0x0/0x55 @ 1                                   
> [    3.207461] NET: Registered protocol family 1                                    
> [    3.211950] initcall af_unix_init+0x0/0x55 returned 0 after 4394 usecs           
> [    3.218624] calling  populate_rootfs+0x0/0xd2 @ 1                                
> [    3.223460] Kernel panic - not syncing: compression method gzip not configured   
> 
> config attached.
> 

Okay, I think I've tracked down the problem.

The issue is that usr/Makefile doesn't correctly filter compression 
methods which we don't support.  This particular case will happen when 
you're building with Ingo's attached configuration *and no bzip2 tool 
installed on the system*.

Basically, the algorithm used in usr/Makefile is simply wrong.

The claim is:

+# Find out "preferred" ramdisk compressor. Order of preference is
+#  1. bzip2 efficient, and likely to be present
+#  2. gzip former default
+#  3. lzma
+#  4. none
+
+# None of the above
+suffix_y                   =
+
+# Lzma, but no gzip nor bzip2
+suffix_$(CONFIG_RD_LZMA)   = .lzma
+
+# Gzip, but no bzip2
+suffix_$(CONFIG_RD_GZIP)   = .gz
+
+# Bzip2
+suffix_$(CONFIG_RD_BZIP2)  = .bz2

This doesn't end up make any sense.  The sanest thing to do is to 
compress with all the compressors that are configured into the kernel, 
and then use the smallest image of the ones that can be produced, 
*including the uncompressed image*.  Including the uncompressed image 
will guarantee that we always have a working option.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/