linux-kernel - Re: [PATCH] Suspend and Resume Support for Intel IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0902180910160.21686@localhost.localdomain>
Date:	Wed, 18 Feb 2009 09:12:34 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Fenghua Yu <fenghua.yu@...el.com>
cc:	Ingo Molnar <mingo@...e.hu>, David Woodhouse <dwmw2@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	'iommu@...ts.linux-foundation.org',
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Suspend and Resume Support for Intel IOMMU



On Wed, 18 Feb 2009, Fenghua Yu wrote:
>
> +static int vtd_enabled;
..
> +static int iommu_resume(struct sys_device *dev)
> +{
..
> +	if (!vtd_enabled)
> +		return 0;

Hmm. Why do this?

Wouldn't it be much more logical to only register the iommu_sysdev if the 
thing is enabled, rather than having an odd flag that gets tested at 
runtime?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/