linux-kernel - Re: [PATCH -mm] documentation: update CodingStyle tips for Emacs users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090218172802.GA1823@cmpxchg.org>
Date:	Wed, 18 Feb 2009 18:28:02 +0100
From:	Johannes Weiner <hannes@...xchg.org>
To:	Patrick Ohly <patrick.ohly@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm] documentation: update CodingStyle tips for Emacs users

On Wed, Feb 18, 2009 at 11:23:59AM +0100, Patrick Ohly wrote:
> On Wed, 2009-02-18 at 09:59 +0000, Johannes Weiner wrote:
> [formatting of line continuation in argument list]
> > Unfortunately, this seems to depend on the maintainer.  Both styles
> > are used all over the kernel but Documentation/CodingStyle and
> > scripts/checkpatch.pl prefer what the above emacs configuration does.
> 
> checkpatch.pl didn't seem to mind either way. I haven't seen this
> particular aspect mentioned in the CodingStyle either.

This is from CodingStyle:

	Outside of comments, documentation and except in Kconfig,
	spaces are never used for indentation, and the above example
	is deliberately broken.

> > I doubt that people do tab tab tab space space space space space by
> > hand, so I strongly suspect that the tab-only zealots don't use emacs
> > which does this adjustment automatically.
> > 
> > You should probably add linux-davem to the above or something.  Or
> > name the coding style after the text-editor the target maintainer
> > uses :-)
> 
> One could also get really fancy and extend the path matching to pick the
> right style depending on the subdirectory ;-)
> 
> Thanks for the clarification. In the future I'll pay closer attention to
> existing code and turn the macro on or off accordingly.

That's probably the best way to judge such details, agreed.  Integrate
well with the surrounding code.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/