linux-kernel - Re: [PATCH] x86: use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090218174543.GA19314@elte.hu>
Date:	Wed, 18 Feb 2009 18:45:43 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Bjorn Helgaas <bjorn.helgaas@...com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	Fenghua Yu <fenghua.yu@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: use dev_printk in quirk message


* Bjorn Helgaas <bjorn.helgaas@...com> wrote:

> This patch changes a VIA PCI quirk to use dev_info() rather than printk().
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>
> ---
>  arch/x86/kernel/pci-dma.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
> index b254285..022833b 100644
> --- a/arch/x86/kernel/pci-dma.c
> +++ b/arch/x86/kernel/pci-dma.c
> @@ -290,8 +290,7 @@ fs_initcall(pci_iommu_init);
>  static __devinit void via_no_dac(struct pci_dev *dev)
>  {
>  	if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && forbid_dac == 0) {
> -		printk(KERN_INFO
> -			"PCI: VIA PCI bridge detected. Disabling DAC.\n");
> +		dev_info(&dev->dev, "disabling DAC on VIA PCI bridge\n");
>  		forbid_dac = 1;
>  	}
>  }

that's one for Jesse i think - Cc:-ed him.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/