| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <499C5C44.4020902@schaufler-ca.com> Date: Wed, 18 Feb 2009 11:06:44 -0800 From: Casey Schaufler <casey@...aufler-ca.com> To: etienne <etienne.basset@...ericable.fr> CC: Paul Moore <paul.moore@...com>, Linux-Kernel <linux-kernel@...r.kernel.org>, linux-security-module@...r.kernel.org, Casey Schaufler <casey@...aufler-ca.com> Subject: Re: [PATCH] SMACK netfilter smacklabel socket match etienne wrote: > hello, > > Paul Moore wrote: > .. > >> Well, since you have some time and willingness to do things "the right way" I >> would recommend dropping these patches (which are really just band-aids) and >> working on the right solution to stored the addresses/masks in a sorted list >> with the mask already applied. >> >> > OK, I'm about to send a new patch; but while testing my patches and reading code, I noticed another bug : > > In smackfs.c:smk_write_netlbladdr > the netmask mask.s_addr is not handled correctly, the netmask should be : > 1- computed in u32 > 2- converted to be32 !! > with current code, a "pseudo u32 mask" is applied to a be32 ipaddr; it occurs to works for "common netmasks" (multiple of 8), not for "intermediate" mask (/15, /25) > Well, that's embarrassing. I am really looking forward to your fixes! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists