linux-kernel - Re: [PATCH -mmotm] asiliantfb: fix ISO declaration/code warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Feb 2009 14:34:44 -0500
From:	Andres Salomon <dilinger@...ued.net>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -mmotm] asiliantfb: fix ISO declaration/code warning

On Wed, 18 Feb 2009 11:12:54 -0800
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Move data declaration before any code:
> 
> drivers/video/asiliantfb.c:515: warning: ISO C90 forbids mixed
> declarations and code
> 
> (from asiliantfb-fix-cmap-memory-leaks.patch)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>


Looks obviously correct to me.

Acked-by: Andres Salomon <dilinger@...ian.org>


> ---
>  drivers/video/asiliantfb.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- mmotm-2009-0218-0215.orig/drivers/video/asiliantfb.c
> +++ mmotm-2009-0218-0215/drivers/video/asiliantfb.c
> @@ -507,12 +507,13 @@ static struct fb_var_screeninfo asiliant
>  
>  static int __devinit init_asiliant(struct fb_info *p, unsigned long
> addr) {
> +	int err;
> +
>  	p->fix			= asiliantfb_fix;
>  	p->fix.smem_start	= addr;
>  	p->var			= asiliantfb_var;
>  	p->fbops		= &asiliantfb_ops;
>  	p->flags		= FBINFO_DEFAULT;
> -	int err;
>  
>  	err = fb_alloc_cmap(&p->cmap, 256, 0);
>  	if (err) {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/