linux-kernel - Re: mpt fusion broken sometime since 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2009 18:40:35 -0800 (PST)
From:	david@...g.hm
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Matthew Wilcox <matthew@....cx>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, DL-MPTFusionLinux@....com
Subject: Re: mpt fusion broken sometime since 2.6.24

On Tue, 17 Feb 2009, david@...g.hm wrote:

>> do you have chance to try current tip/master
>> http://people.redhat.com/mingo/tip.git/readme.txt
>> or 2.6.29-rcX
>> plus following patch?
>
> I will see about trying this.

does the fact that I am compiling a monolithic kernel (no modules) make 
any difference related to the patch below?

David Lang

>> or can you check if there is update fw for your LSI card?
>
> this is more work, I'll look into that as well.
>
> David Lang
>
>> [PATCH] mpt: fix enable lsi sas to use msi as default
>> 
>> Impact: fix bug
>> 
>> the third param in module_param(,,) is perm instead of default value.
>> we still need to assign default at first.
>> 
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> 
>> ---
>> drivers/message/fusion/mptbase.c |    4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> Index: linux-2.6/drivers/message/fusion/mptbase.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/message/fusion/mptbase.c
>> +++ linux-2.6/drivers/message/fusion/mptbase.c
>> @@ -90,8 +90,8 @@ module_param(mpt_msi_enable_fc, int, 0);
>> MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \
>> 		controllers (default=0)");
>> 
>> -static int mpt_msi_enable_sas;
>> -module_param(mpt_msi_enable_sas, int, 1);
>> +static int mpt_msi_enable_sas = 1;
>> +module_param(mpt_msi_enable_sas, int, 0);
>> MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \
>> 		controllers (default=1)");
>> 
>> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/