linux-kernel - Re: [PATCH] spi-gpio: Sanitize MISO bitvalue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Feb 2009 16:29:56 -0800
From:	David Brownell <david-b@...bell.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Michael Buesch <mb@...sch.de>, linux-kernel@...r.kernel.org,
	openwrt-devel@...ts.openwrt.org
Subject: Re: [PATCH] spi-gpio: Sanitize MISO bitvalue

On Wednesday 18 February 2009, Andrew Morton wrote:
> If this function is speed-critical (which is what David's comment
> implies) then perhaps this should be "fixed" by tightening up the
> (presently apparently undocumented) interface?  And then speeding up
> all the other getmiso() implementations?

All the per-bit GPIO functions can be speed-critical,
which is why they use the zero/nonzero convention
instead of demanding extra instructions to switch to
the zero/one convention.

This particular function needs the zero/one convention;
in that respect it's unusual.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/