linux-kernel - Re: [PATCH 01/10] vmalloc: call flush_cache_vunmap() from unmap_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902192306.28360.nickpiggin@yahoo.com.au>
Date:	Thu, 19 Feb 2009 23:06:27 +1100
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	Tejun Heo <tj@...nel.org>
Cc:	rusty@...tcorp.com.au, tglx@...utronix.de, x86@...nel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com, jeremy@...p.org,
	cpw@....com, mingo@...e.hu
Subject: Re: [PATCH 01/10] vmalloc: call flush_cache_vunmap() from unmap_kernel_range()

On Wednesday 18 February 2009 23:04:27 Tejun Heo wrote:
> Impact: proper vcache flush on unmap_kernel_range()
>
> flush_cache_vunmap() should be called before pages are unmapped.  Add
> a call to it in unmap_kernel_range().
>
> Signed-off-by: Tejun Heo <tj@...nel.org>

Shouldn't this go as a fix to mainline and even .stable?

Otherwise:
Acked-by: Nick Piggin <npiggin@...e.de>

> ---
>  mm/vmalloc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 75f49d3..c37924a 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1012,6 +1012,8 @@ void __init vmalloc_init(void)
>  void unmap_kernel_range(unsigned long addr, unsigned long size)
>  {
>  	unsigned long end = addr + size;
> +
> +	flush_cache_vunmap(addr, end);
>  	vunmap_page_range(addr, end);
>  	flush_tlb_kernel_range(addr, end);
>  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/