linux-kernel - Re: [PATCH] hwmon/hdaps: remove redundant sysfs invert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499DBA5B.10908@suse.de>
Date:	Thu, 19 Feb 2009 21:00:27 +0100
From:	Frank Seidel <fseidel@...e.de>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	linux kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, rlove@...ve.org, protasnb@...il.com,
	Michael Ruoss <miruoss@...dent.ethz.ch>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Tim Gardner <tim.gardner@...onical.com>,
	Frank Seidel <frank@...eidel.de>, multinymous@...il.com
Subject: Re: [PATCH] hwmon/hdaps: remove redundant sysfs invert

Hi,

Jean Delvare wrote:
> On Thu, 19 Feb 2009 13:44:43 +0100, Frank Seidel wrote:
>> -	hdaps_invert = invert;
>> -	hdaps_calibrate();
> 
> Apparently recalibration is necessary when you change the inversion
> settings. The module parameter, which you made writable in a previous
> patch, does _not_ recalibrate when changed.
> 
> So it was probably not such a good idea to make the module parameter
> writable, and that should be reverted. Which in turn means that the
> sysfs attribute "invert" has to stay.

Fully agree. I'll post a module-writeable revert patch tomorrow.

Thanks,
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/